Convert TestMemSqlTypeMapping to use SqlDataTypeTest

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)

https://trino.io

Apache License 2.0

10.3k stars 2.97k forks source link

Closed findepi closed 2 years ago

findepi commented 3 years ago

Migrate the tests from DataTypeTest to SqlDataTypeTest.

DataTypeTestToSqlDataTypeTestConverter (being added in https://github.com/prestosql/presto/pull/6391) may aid the migration.
ideally the work should be done incrementally (in small steps) to facilitate the review process
see also https://github.com/prestosql/presto/issues/6392, as MySQL and MemSQL tests are similar

albericgenius commented 3 years ago

@findepi Could I take over this issue as my first task?

findepi commented 3 years ago

@albericgenius this is already being worked on by @Atema in https://github.com/trinodb/trino/pull/7202. It seems the primary obstacle was the CLA cc @martint

cc @hashhar

albericgenius commented 3 years ago

got you and thanks