tooptoop4
commented
3 years ago this solves it:
(patched on v336) --> presto-main\src\main\java\io\prestosql\server\HttpRequestSessionContext.java
private static Map<String, String> parseProperty(MultivaluedMap<String, String> headers, String headerName)
{
Map<String, String> properties = new HashMap<>();
for (String header : splitHttpHeader(headers, headerName)) {
List<String> nameValue = Splitter.on('=').trimResults().splitToList(header);
assertRequest(nameValue.size() == 2, "Invalid %s header", headerName);
try {
properties.put(nameValue.get(0), urlDecode(nameValue.get(1)));
}
catch (IllegalArgumentException e) {
throw badRequest(format("Invalid %s header: %s", headerName, e));
}
}
try {
if (headerName.equals(PRESTO_EXTRA_CREDENTIAL)) {
List<String> tempAuth = headers.get("Authorization");
if (tempAuth != null) {
String origHeader = String.valueOf(tempAuth);
String header = origHeader.substring(1,origHeader.length()-1);
int space = header.indexOf(' ');
String credentials = decodeCredentials(header.substring(space + 1).trim());
List<String> parts = Splitter.on(':').limit(2).splitToList(credentials);
String user = parts.get(0);
String password = parts.get(1);
if (password != null && user != null) {
properties.put("user", user);
properties.put("password", password);
}
}
}
} catch (Exception e) {
}
return properties;
}
private static String decodeCredentials(String credentials)
{
try {
return new String(Base64.getDecoder().decode(credentials), ISO_8859_1);
}
catch (IllegalArgumentException e) {
}
return null;
}echo " connector.name=sqlserver connection-url=jdbc:sqlserver://somehost;databaseName=somedb;authenticationScheme=JavaKerberos;domain=NTADMIN;integratedSecurity=true;jaasConfigurationName=SQLJDBCDriver case-insensitive-name-matching=true user-credential-name=user password-credential-name=password unsupported-type-handling=IGNORE " > etc/catalog/coreuat.properties echo '-Djava.security.auth.login.config=/a/path/conf.jaas' >> etc/jvm.config echo 'SQLJDBCDriver { com.sun.security.auth.module.Krb5LoginModule required useTicketCache=false doNotPrompt=false; };' > /a/path/conf.jaas
matt12eagles
Presto connecting to a SQLServer catalog (with end user creds) works when extraCredentials of user:password is passed in, but not all clients support extraCredentials. Would be great to have a catalog level property set in the properties file to do this ie passthroughAuth=true
Below is error without extraCredentials being passed: