Single SPI method for resolving relation name - Githubissues

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)

https://trino.io

Apache License 2.0

10.27k stars 2.95k forks source link

Single SPI method for resolving relation name #9400

Open findepi opened 3 years ago

findepi commented 3 years ago

We have multiple methods in ConnectorMetadata that effectively resolve relation name:

getTableHandle
getView
getMaterializedView
getSystemTable
redirectTable

Replace these with a single method e.g. resolveRelation so that

the SPI makes it clear that there cannot be a table and view with the same name (see e.g. https://github.com/trinodb/trino/pull/7484#discussion_r608757656, https://github.com/trinodb/trino/pull/7475#issuecomment-812002585)
a connector is consulted once for a relation
- besides a SPI change, this requires sharing TableHandle when there are multiple Table Scans for the same relation within a query

See also: https://github.com/trinodb/trino/issues/9253 and https://github.com/trinodb/trino/issues/9253#issuecomment-927747023

findepi commented 3 years ago

cc @losipiuk @phd3 @martint @kasiafi @sopel39