trioderegion / dnd5e-helpers

Little helpers for little 5e tasks.
MIT License
27 stars 22 forks source link

this.hud is undefined #310

Open kiligir opened 1 year ago

kiligir commented 1 year ago

Absolutely no idea whatsoever what is causing the issue here, but this gets thrown on load and the canvas doesn't render on V10 of Foundry. I'll include all my mods in case that helps, but Find the Culprit! definitely identified this mod as the issue.

Active Modules:

About Time v; Active-Auras v; Advanced Macros v; Adventure Music v; Alternative Pause Icon v; Always HP v; Ambient Doors v; Autocomplete Whisper v; Automated Animations v; Automated Evocations - Companion Manager v; Better Roofs v; Boy King of Idaho Music Pack v; Break Time v; Button Overflow v; Cautious Gamemaster's Pack v; Close Player Art v; Color Picker v; Combat Booster: Turn Marker, Recent Actions and more v; Combat Enhancements v; Combat Focus v; Combat Numbers v; Compendium Folders v; Connection Monitor v; Crash's Tracking & Training (5e) v; D&D Beyond Importer v; DF Chat Enhancements v; DFreds Convenient Effects v; DFreds Droppables v; DFreds Effects Panel v; DFreds Pocket Change v; DF Scene Enhancement v; Dice So Nice! v; Dice Tray v; DnD5e Drag Ruler Integration v; Door Colors v; Drag Ruler v; Dynamic effects using Active Effects v; Easy Notes v; Entice with Dice so Nice v; Ethck's 5e Downtime Tracking v; Filepicker + v; Find the culprit v; Follow Me! v; Forien's Quest Log v; Forien's Unidentified Items v; FXMaster v; GM Notes v; GM Screen v; Health Estimate v; Hidden Soundtracks v; Hide GM Rolls v; Hover Distance v; Iconizer v; Illandril's Inventory Sorter (5e) v; Illandril's Token Tooltips v; Image Context v; Image Hover v; Initiative Double Click v; Introduce Me v; Item Macro v; Item Piles v; Ivan Duch's Music Packs v; JB2A - Patreon Complete Collection v; Join Combat v; Journal Backlinks v; Kandashi's Fluid Canvas v; Lancer Clocks v; Lasers and Lightbeams v; Lazy Money v; Let's Trade 5e v; Levels v; Levels - Depth Blur v; lib - Color Settings v; Library: Chat Commands v; libWrapper v0; LootsheetNPC5e v; Magic Items v; Mastercrafted - Crafting Manager v; Material Deck v; Math.js vvtt2; Midi QOL v; Minimal UI v; Module Compatibility Checker v; Monk's Active Tile Triggers v; Monk's Little Details v; Monk's Player Settings v; Monk's Sound Enhancements v; Monk's TokenBar v; Monster Blocks v; Narrator Tools v; Navigation Name v; Nice More Dice v; Ownership Viewer v; Party Overview v; Perfect Vision v; PnP - Pointer and Pings! v; PopOut! v; Quick Combat v; Quick Doors v; Quickdraw v; Quick Insert - Search Widget v; Ready Set Roll for D&D5e v; Salvage Yard v; Sane Magical Item Prices Compendium v; Select tool everywhere v; Sequencer v; Settings Extender v; Shared Vision v; Show Notes v; Sidebar Macros v; Simple Calendar v; Skill Customization for D&D5e v; socketlib v; Socket Macros v; Spell Level Buttons for DnD 5e v; Sweet Nothings v; Syrinscape Control v; Talis Dice v; The Forge v; The Forge: More Awesomeness v; The Griffon's Saddlebag, Pack 1 v; The Griffon's Saddlebag, Pack 2 v; The Griffon's Saddlebag, Pack 2021-02 v; The Griffon's Saddlebag, Pack 2021-03 v; The Griffon's Saddlebag, Pack 2021-04 v; The Griffon's Saddlebag, Pack 2021-05 v; The Griffon's Saddlebag, Pack 2021-06 v; The Griffon's Saddlebag, Pack 2021-07 v; The Griffon's Saddlebag, Pack 2022-01 v; The Griffon's Saddlebag, Pack 2022-02 v; The Griffon's Saddlebag, Pack 2022-03 v; The Griffon's Saddlebag, Pack 2022-04 v; The Griffon's Saddlebag, Pack 2022-05 v; The Griffon's Saddlebag, Pack 2022-06 v; The Griffon's Saddlebag, Pack 2022-07 v; The Griffon's Saddlebag, Pack 3 v; The Griffon's Saddlebag, Pack 4 v; The Griffon's Saddlebag, Pack 5 v; The Griffon's Saddlebag, Pack 6 v; The Griffon's Saddlebag, Pack 7 v; TheRipper93's Module Hub v; Tidy5e Sheet v; Tidy UI - Game Settings v; Times Up v; Token Action HUD v; Token Auras v; Token Elevator v; Token Flip v; Token Frames v; Token Health v; Tokenizer v; Token Magic FX v; Token Talk v; VoiceActor by Blitz v; Wall Height v; Warp Gate v; Weather Control v; Window Controls v; WTF: What the Flag? v;

akrigline commented 1 year ago

This module is not marked ready for v10, so I wouldn't expect it to work on that version of core.

BarovianBadass commented 1 year ago

As verification, I am also having the issue with the canvas not rendering.

webmaster94 commented 1 year ago

I am under the impression that this module is not going to be updated for v10, based on the following in the readme: Compatibility Notes v3.0.4 (legacy 0.8.x generation): Requires dnd5e system version 1.5.5 or greater. v4.x (legacy v9 generation): Requires dnd5e system version 1.6.0 or greater. v5.x (v10+ generation): NOT PLANNED FOR DEVELOPMENT

I will probably submit this to the league for orphan modules to see if anyone wants to take up development. In the meantime this should fix the critical error:

Replace lines 540 through 542 in scripts/modules/ActionManagment.js with the following. //from foundry.js:46127 as of v10.1288 if ( !src ) return; let tex = await loadTexture(src, {fallback: "icons/svg/hazard.svg"}); let icon = new PIXI.Sprite(tex); if ( tint ) icon.tint = tint; return this.effects.addChild(icon);

I will submit a merge request and maybe the author will update the module with this at least to get it so it doesn't cause the canvas to not load. I haven't checked everything in the module but it appears most of the features are working with this code change. I am afraid that I am not skilled enough to maintain the module myself or I would.

Hope this helps.

webmaster94 commented 1 year ago

Sorry the new lines were not added properly in my comment, be sure to put a new line after each semicolon like this: image