search

tripal / brapi

Breeding API client-server implementation (v1 & v2) for Tripal
https://www.drupal.org/project/brapi
0 stars 3 forks source link

Implement pre-filtering on data types #21

Closed guignonv closed 5 years ago

guignonv commented 5 years ago

Some data types may need to be pre-filtered. For instance germplasm and sample share the same table but differ by type_id. The type_id is filtered on the search call but not when an identifier is provided. Therefore, the sample/{sampleDbId} will work with a germplasmDbId while it should not because no-prefiltering occurs. Another case is the traits/ call that will list all the CV terms, even non-trait ones. Pre-filtering should be specified in the brapi_get_data_mapping() call.

guignonv commented 5 years ago

Fixed by commit 027bf89d94d2c510f22840ae80ef4fea29b5c26d.