search

tripal / t4d8

This is a temporary repository for Drupal 9 upgrade for Tripal v4. It is meant to house issues related to the upgrade.
GNU General Public License v2.0
1 stars 10 forks source link

Setup of IDSpace and Vocab in testing no longer has errors #214

Closed spficklin closed 2 years ago

spficklin commented 2 years ago

This PR is for @4ctrl-alt-del . This fixes a few bugs I found with the IDSpace and Vocabulary collections while trying to setup testing. They are all very minor tweaks that should be self-evident. Ignore the code for testing as I'm still working on that.

4ctrl-alt-del commented 2 years ago

So it seems like errors are still happening in your test code with the automated checking? Do they not occur when you run it on your machine? I imagine not I remember you showing me running the test with no errors.

That makes me a little confused since the failed checks above seem to be happening in your unit testing code...

spficklin commented 2 years ago

I was only testing the functional test that I made and not the entire test suite. I believe the tests that are failing are from different tests.

4ctrl-alt-del commented 2 years ago

OK this should be fine.