search

tripal / t4d8

This is a temporary repository for Drupal 9 upgrade for Tripal v4. It is meant to house issues related to the upgrade.
GNU General Public License v2.0
1 stars 10 forks source link

Tripal Id Space and Vocabulary Plugins #227

Closed 4ctrl-alt-del closed 2 years ago

4ctrl-alt-del commented 2 years ago

The tripal fields branch is ready to be merged to the main branch with the new and fully functional id space and vocabulary plugin system. This includes working chado plugins implemented by @spficklin.

spficklin commented 2 years ago

To add to this. I don't think we need anything more in terms of testing. There are, almost 200 assertions in the functional tests for this work so unless @laceysanderson thinks we need another code review I would suggest this is ready for merging.

spficklin commented 2 years ago

Although before we commit, we should figure out why GitHub is showing that "Water Coyote" has contributed a lot of code rather than @4ctrl-alt-del

4ctrl-alt-del commented 2 years ago

I resolved the contribution error with github, they said it was some sort of database error. It should now show "Josh B".

spficklin commented 2 years ago

I just had a quick conversation with @laceysanderson on Slack about this PR. I need it for doing tests with the ChadoStorage class and she agreed it looks good to merge. So merging.