search

tripal / t4d8

This is a temporary repository for Drupal 9 upgrade for Tripal v4. It is meant to house issues related to the upgrade.
GNU General Public License v2.0
1 stars 10 forks source link

GFF3 Importer #275

Closed risharde closed 1 year ago

risharde commented 1 year ago

This is the working version of GFF3 Importer compatible with Drupal 9. Old deprecated functions for logging and using ChadoRecord calls now use the Tripal DB functions Removed unnecessary comments, print_r statements etc.

Tested on Citrus sinensis and Arabidopsis thaliana without errors on console. @spficklin also helped me verify that data was being added to the necessary tables.

TODO: Unit testing code (branching out from this branch).

spficklin commented 1 year ago

This is good. I made a few cleanups, some minor corrections, and fixed the issues Lacey raised. I also did a full test loading a GFF3 and all looks good. It still needs the functional testing to make sure all is good, but I think this can be merged once all the CI tests finish.

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit c0c9d7a7 and detected 30 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 30

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.4% (-3.0% change).

View more on Code Climate.

spficklin commented 1 year ago

Checks passed! Merging