search

tripal / t4d8

This is a temporary repository for Drupal 9 upgrade for Tripal v4. It is meant to house issues related to the upgrade.
GNU General Public License v2.0
1 stars 10 forks source link

FASTA Importer #288

Closed risharde closed 1 year ago

risharde commented 1 year ago

This PR is the new FASTA importer that is compatible with Drupal 9.x. Replaced deprecated functions. Used the new logger functions. Converted some sql statements to use the database api statements. Tested with Citrus sinensis using the Tripal 3 docs (https://tripal.readthedocs.io/en/latest/user_guide/example_genomics/genomes_genes.html)

It would be nice to test this with other bigger FASTA files, that would be great!

@spficklin @laceysanderson

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit a01b03ac and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 13

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 32.3% (-1.1% change).

View more on Code Climate.

laceysanderson commented 1 year ago

Closing this as it will not be merged before alpha1 and we are moving back to tripal/tripal repository. This work was moved to a new branch in tripal/tripal and this PR linked.

Information: https://github.com/tripal/tripal/issues/1346

Do not make any further changes on this functionality in this repository.