tripal / t4d8

This is a temporary repository for Drupal 9 upgrade for Tripal v4. It is meant to house issues related to the upgrade.
GNU General Public License v2.0
1 stars 10 forks source link

Invalid or unsupported Chado schema version '1.3x'. #301

Closed spficklin closed 1 year ago

spficklin commented 1 year ago

When running functional tests both myself and @risharde were getting the error message: Invalid or unsupported Chado schema version '1.3x'. It seems that this problem occurs because the version is getting set here:

https://github.com/tripal/t4d8/blob/c4ce1133352901916e8b8cbe9f97a173a30fd54e/tripal_chado/src/Database/ChadoConnection.php#L243-L245

But this shouldn't be happening. this code should only be called if there is no proper version in the chadoprop table. The code a bit higher up is supposed to check this:

The version should be set correctly for testing as per this bit of SQL:

https://github.com/tripal/t4d8/blob/c4ce1133352901916e8b8cbe9f97a173a30fd54e/tripal_chado/tests/fixtures/version.sql#L42-L45

spficklin commented 1 year ago

I should add, in my tv4g1-129-TripalFields-complex-properties branch I removed the 'x' in the 1.3x so that testing would continue on.