search

tripal / t4d8

This is a temporary repository for Drupal 9 upgrade for Tripal v4. It is meant to house issues related to the upgrade.
GNU General Public License v2.0
1 stars 10 forks source link

Fix issue #324 by removing old drush depenendancy. #325

Closed laceysanderson closed 1 year ago

laceysanderson commented 1 year ago

Yesterday @spficklin mentioned that tripaldocker was failing to build locally for him sometimes and then last night it happened to me as well. My error was due to composer failing to resolve dependancies.

This PR removes an old drush dependency from tripaldocker which was added when installing composer. Specifically,

composer --quiet require drush/drush:8.*

Drush is still installed via the Dockerfile but does not have the version indicated. This allows composer to make the right decisions about dependencies.

Testing

No testing required as the automated tests will build the docker with all versions of Drupal indicated and using PHP 8.0 and 8.1 so this should test all combinations of dependency resolving that composer needs to worry about.

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 783ce9e9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 32.6% (0.0% change).

View more on Code Climate.