search

tripal / tripal

The Tripal package is a suite of Drupal modules for creating biological (genomic, genetic, breeding) websites. Visit the Tripal homepage at http://tripal.info for documentation, support, and other information. The Drupal project page is at http://drupal.org/project/tripal.
GNU General Public License v2.0
67 stars 49 forks source link

Add in schema for options all supported tripal_layout field group options. #1993

Closed laceysanderson closed 1 month ago

laceysanderson commented 1 month ago

Bug Fix

Issue #1862

Tripal Version:

Description

I missed this in the original PR referenced 🙈 We need schema definitions for all options supported in the YAML but the original PR only included the main ones we had previously used and that are represented in the test yamls. This PR adds all the supported ones.

Note: this came about because we are using the Tripal Layout in our TripalCultivate extension module and it's test yamls have a description. As such all our tests are failing with a missing schema note about the description.

Screenshot 2024-10-07 at 4 40 57 PM

Testing?

This is a schema only change. It is much more difficult to test manually then it is worth. As such, code review and confirm it doesn't break existing tests.

laceysanderson commented 1 month ago

Thanks for the quick review @dsenalik!