search

tripal / tripal_blast

Provides an user interface to BLAST on Tripal sites.
https://tripal.github.io/tripal_blast/
5 stars 13 forks source link

[Question] Doubt regarding the settings while setting up a blast database #111

Open shreyas-a-s opened 1 month ago

shreyas-a-s commented 1 month ago

Hi there!

I have been using tripal_blast for a drupal 7 website and wanted to migrate to drupal 10 and thereby the updated tripal_blast. Even though it's in early stages, I wanted to contribute to the community in ways I can. I have manually cloned the repo and installed the module in a drupal 10 + tripal 4 website.

These options while setting up a new blast database seems new to me. I don't remember setting options like these while using drupal 7:

Screenshot from 2024-09-26 23-39-57

Could you please explain to me what these options mean and whether there is any default values for them?

laceysanderson commented 1 month ago

Hmmm.... you are right -those are new. They must have been added by my colleague 🤔 They look to be related to configuring link-outs. In the Drupal 7 version you just chose your link out type and that was all the granularity you had but it looks like in this version you have more control over it 🤔

For now I think we can just make those not required by changing #required => FALSE for these 3 form elements (defined here: https://github.com/tripal/tripal_blast/blob/2.x/src/Form/TripalBlastDatabaseForm.php#L84-L112).

You had mentioned you would like to contribute to the community so if you wanted to make a small PR setting those 3 fields to no longer be required that would be great :-) Then we just need to test that we can create the blast database without them set.

shreyas-a-s commented 1 month ago

Hi @laceysanderson,

First of all, thanks for your prompt response to my question. I understand that they might have been marked as required in an update to the code.

Regarding the PR, this change seems pretty small and I'll submit it asap. I'm always more than happy to contribute to open-source projects.

shreyas-a-s commented 1 month ago

I have submitted the PR at link. Please check whether this is what you meant. Also, I did a small testing by creating a blast database by filling the form and there were no errors while creating it. But still it would be great if you could also do some testing and make sure it is perfect.

Also if I can help in any other way to the project, please mention.