tripal / tripal_doc

Official Documentation for the Tripal Platform
https://tripaldoc.readthedocs.io/en/latest/
GNU General Public License v3.0
2 stars 3 forks source link

User permissions docs + Example Genomics Site Building Docs #52

Closed pdtouch closed 8 months ago

pdtouch commented 11 months ago

Created documentation for the user permissions pages under site administration.

laceysanderson commented 8 months ago

@pdtouch it looks like the example site building docs ended up in this PR as well since you used the same branch 🙈 This is one of those "features" of git/github that often cause confusion. Once you create a PR it is tied to the branch for the lifetime of the PR. This allows us to update PRs based on review :-) but it also means that if we start working on other functionality we need to make a new branch. This is often missed when people are using their own forks 💞

I understand that you are working on another project for the next couple of weeks so we'll just leave this all in one. Can you provide a quick update on where you are? perhaps we can review and merge in it's current state?

pdtouch commented 8 months ago

@pdtouch it looks like the example site building docs ended up in this PR as well since you used the same branch 🙈 This is one of those "features" of git/github that often cause confusion. Once you create a PR it is tied to the branch for the lifetime of the PR. This allows us to update PRs based on review :-) but it also means that if we start working on other functionality we need to make a new branch. This is often missed when people are using their own forks 💞

I understand that you are working on another project for the next couple of weeks so we'll just leave this all in one. Can you provide a quick update on where you are? perhaps we can review and merge in it's current state?

Documentation pages for creating an example site in Tripal 4 has been pushed to 49-addPlaceholderPages. Some functionality of Tripal 3 not yet available in Tripal 4 to my knowledge are mentioned in notes. It can be reviewed and any suggestions to improve can be incorporated.

Documentation for Users, Permissions and Roles have been added as you mentioned earlier.

Yes, a different branch name for this makes sense.

I think it can be merged if it looks ok.

Thanks!