search

tripflex / WifiWizard2

A Cordova plugin for managing Wifi networks (new version of WiFiWizard) - Latest is version 3+
https://www.npmjs.com/package/cordova-plugin-wifiwizard2
Apache License 2.0
122 stars 146 forks source link

Add support for Android 10 #108

Closed wizevlad closed 3 years ago

eliadAfeka commented 3 years ago

@wizevlad - are you going to merge it ?

glenngr commented 3 years ago

Any news here?

tripflex commented 3 years ago

@wizevlad thank you for submitting a PR, can you please fix the formatting in WifiWizard2.js as this breaks the diff due to the changes made in the JS file.

@eliadAfeka @glenngr can you confirm that this fixed issues for Android 10?

tripflex commented 3 years ago

I believe this is related to and would conflict with https://github.com/tripflex/WifiWizard2/pull/104

Personally I would be in preference of favoring #104 than this one due to all the formatting changes which will make it more difficult to review later on if need to come back to this.

glenngr commented 3 years ago

@tripflex I can confirm that #104 fixes the issue. I propose closing this PR and approving #104

tripflex commented 3 years ago

@glenngr thanks for confirming, yeah all the formatting changes hurt me head trying to dig through the actual changes in the PR. I'm going to close this one in favor of merging #104