search

tripflex / WifiWizard2

A Cordova plugin for managing Wifi networks (new version of WiFiWizard) - Latest is version 3+
https://www.npmjs.com/package/cordova-plugin-wifiwizard2
Apache License 2.0
123 stars 146 forks source link

Refactor Android/iOS/Cordova Code Base #28

Open tripflex opened 6 years ago

tripflex commented 6 years ago

After my initial fork of this plugin, things have been constantly growing and being added, resulting in a large single file with ~2k lines of code. Need to clean up code base, and move methods/functions/classes to separate files to keep clean codebase ... looking for any Android and Cordova developers out there who would be willing to help with this.

Let's get this thing cleaned up and organized! Unfortunately my time is limited as I do not have any projects using Cordova that bring in any kind of income, this was specifically for personal and other open source projects, so looking for others who may be willing to help!

tripflex commented 5 years ago

https://github.com/dpa99c/cordova-diagnostic-plugin/

This plugin is a perfect example of a well organized and clean code base for Cordova project

kalicki commented 5 years ago

ios: idea.. refactor to swift (4/5)

CurtisMorice commented 5 years ago

I am working with this in my app everyday and would like to help if I can. I am pretty junior and have only been coding about a year now. How can I help?

arsenal942 commented 5 years ago

I am working with this in my app everyday and would like to help if I can. I am pretty junior and have only been coding about a year now. How can I help?

@CurtisMorice Just like any other open-source project, if you see room for improvement, submit a pull request so it can be reviewed. :)

AbdulRahman577 commented 1 year ago

May I get the example for migrating this to implement in the capacitor app? What I have done is, just copy the java file into the Android app main directory as the subpackage and then add this wifiwizard.java file as a custom plugin in the capacitor.config.json. And some thing modified inside the wifiwizard2.java as for the capacitor framework, which is, import com. getcapacitor.CapacitorPlugin;

public class WifiWizard2 extends CapacitorPlugin {....

Like above,

is my implementation is correct for capacitor environment?

And how to remove the cordova interface in the wifiwizard2.java file, Or is it okay to be there for building? Please suggest way to understand this