search

tripflex / WifiWizard2

A Cordova plugin for managing Wifi networks (new version of WiFiWizard) - Latest is version 3+
https://www.npmjs.com/package/cordova-plugin-wifiwizard2
Apache License 2.0
123 stars 146 forks source link

Update plugin id to match change in package.json #82

Open saoron opened 5 years ago

saoron commented 5 years ago

Urgent!

the Id change to the standard cordova format is great but someone forgot to change this in the config.xml as well making the plugin uninstallable..

arsenal942 commented 5 years ago

@tripflex You'll need to publish to npm so can you handle this PR please

kalicki commented 5 years ago

Up?!

tripflex commented 5 years ago

Related to https://github.com/tripflex/WifiWizard2/issues/49

Basically when i first forked this plugin I didn't follow the standard of using cordova-plugin-XXXX in the naming, which is how it should be, so probably need to rename this repo to use the correct format of naming for the plugin

tripflex commented 5 years ago

Not really sure what the best way to handle this would be, for existing users using the WifiWizard2 to update for future users to use cordova-plugin-wifiwizard2 ... thoughts? @arsenal942 ? I guess we do need to update this when it's pushed to npm, so maybe create a separate branch specific for backwards compatibility, and use that branch when pushing to npm just making sure the name matches?

arsenal942 commented 5 years ago

Not really sure what the best way to handle this would be, for existing users using the WifiWizard2 to update for future users to use cordova-plugin-wifiwizard2 ... thoughts? @arsenal942 ? I guess we do need to update this when it's pushed to npm, so maybe create a separate branch specific for backwards compatibility, and use that branch when pushing to npm just making sure the name matches?

@tripflex Late reply sorry. It won't impact their live/currently published applications so we COULD replace the existing branch and it is on the developers to simply re-install the plugin with the new Id. If we don't have a backwards compatible branch, all we would break is new builds where their build process will freak out about not finding the right plugin.

I'd be more inclined to do that otherwise developers will continue to use the 'backwards compatible' version and never update the Id to match.

arsenal942 commented 5 years ago

@tripflex I am going to merge this. You will need to do what I said above after I merge.