search

triplea-game / dice-server-js

The new TripleA dice server powered by Node.js
GNU Affero General Public License v3.0
6 stars 6 forks source link

More tests #16

Closed RoiEXLab closed 5 years ago

RoiEXLab commented 5 years ago

Adds a couple more tests to this repository. I'd appreciate if someone could help me out with this to get this software production-ready soon. The client side code should be fairly easy to write.

@ssoloff Alternatively if you think you can figure out how to change the email config for MARTI before christmas that would be a viable option too, for now. This software is our backup plan.

ssoloff commented 5 years ago

@RoiEXLab I'm going to be sans dev environment for the next 7-10 days, so I won't be able to do any coding during that time.

how to change the email config for MARTI before christmas

BTW, why do we have a deadline so soon? I thought @prastle renewed the tripleawarclub.org domain for another year?

Regardless, I don't think we should switch to this new dice server cold. We need some overlapping period where both MARTI and this server are running Just In Case.

Can you please create an issue in the MARTI repo that describes exactly what "change the email config" requires? Specifically, how can one test and know when such a changed configuration is working.

RoiEXLab commented 5 years ago

@ssoloff

BTW, why do we have a deadline so soon? I thought @prastle renewed the tripleawarclub.org domain for another year?

I'm not 100% sure if I interpreted this correctly, but according to @prastle having a whois guard costs extra, so having a migration soon™ will allow him to avoid this cost because in this case the domain is not really visible anymore?

Regardless, I don't think we should switch to this new dice server cold. We need some overlapping period where both MARTI and this server are running Just In Case.

Agreed, but if after half a year of testing on 1.10 it turns out to be working well, we could directly jump to the newer version on 1.9 and can avoid having to actually migrate the server.

Can you please create an issue in the MARTI repo that describes exactly what "change the email config" requires? Specifically, how can one test and know when such a changed configuration is working.

Will do. I don't know what exactly needs to be done (otherwise I could simply do it on my own), but I have an idea what could possibly work. In any case everything that needs to be done to check if everything works is to test MARTI from the client and check if the email you receive is in fact coming from the new domain.

prastle commented 5 years ago

@RoiEXLab @ssoloff yes it is renewed for another year. Yes I would like to add the "Guard" if we can't migrate by January. I will check on the cost. Edited in ... Cost = +$10.00 yr +taxes