search

triplea-game / triplea-game.github.io

TripleA Website
https://triplea-game.org/
GNU Affero General Public License v3.0
13 stars 18 forks source link

Move win32 download to a link #318

Closed DanVanAtta closed 5 years ago

DanVanAtta commented 5 years ago

There are more than expected windows 32 bit downloads than we would expect. To discourage users from choosing the wrong windows distro, the win32 download button is converted here to a link to "hide it". This will hopefully make it easier to pick the right distribution version, and if someone is not paying a lot of attention and is clicking the first thing that they see that says "windows", then they'll click the 64 bit windows DL now instead of 'accidently' getting the 32 bit.

Screenshot from 2019-06-10 11-13-53

DanVanAtta commented 5 years ago

@RoiEXLab some javascript to bring the right version to the top would be great. We'd want to be careful the UX was good to still find other kinds of downloads and not necessarily hide everything else.

For example, I think adoptopenjdk does this pretty nicely: https://adoptopenjdk.net/

My 2 cents, this is the right move for now. When we have the JS in place, it'll be good to update further with that. We don't have to move to the best solution immediately, or even at all. Looking at the website traffic, it is anemic. There might be higher ROI efforts.

RoiEXLab commented 5 years ago

Well I have some spare time right now, it would take me half an hour to change the code so only a single option is shown by default. So if you'd prefer that instead I could do it real quick. I was thinking about adoptopenjdk as well, but the biggest restriction is that we have to rely on javascript for everything, so we are a little bit more limited on the possibilities.

DanVanAtta commented 5 years ago

IMO I'd merge to take the pressure off and then rebase and work from there for a fast iteration. But really up to you @RoiEXLab

RoiEXLab commented 5 years ago

319

Took me longer than expected, I had to fix all the JS mess I created back in the day. It's stunning how much my code evolved since then ^^

DanVanAtta commented 5 years ago

Good stuff @RoiEXLab I hear ya on code style changing. I've noticed the same looking at some of my earlier stuff working on TripleA. The updated JS is a good bit cleaner FWIW, I follow it much more easily!