triplea-game / triplea-game.github.io

TripleA Website
https://triplea-game.org/
GNU Affero General Public License v3.0
12 stars 16 forks source link

Link rel meta tag in site html refers to http://localhost:4000/ #348

Closed tvleavitt closed 2 months ago

tvleavitt commented 4 years ago

The following meta tag is embedded in the site content:

Based on the information below, I believe this is invalid:

The Canonical meta tag is actually a link element. By adding it you define which URL is the original URL of a page. If you have a page with both a mobile and a desktop version, Google sees these as duplicate versions of the same page.

If the same information is available on multiple URLs, then there is duplicate content. The best solution is to prevent duplicate content from occurring. But in other cases, the canonical tag is the best way to resolve duplicate content.

https://www.metatags.org/all-meta-tags-overview/the-unknown-metatags/canonical-tag/

DanVanAtta commented 2 years ago

Any clue where that value of 'localhost:4000' is coming from @tvleavitt ? @RoiEXLab ?

RoiEXLab commented 2 years ago

@DanVanAtta well the tag is defined here: https://github.com/triplea-game/triplea-game.github.io/blob/69e6873a79c8a9604c72c59a9776fa5422fe4cde/_includes/head.html#L10

Because Jekyll listens on localhost:4000 by default that's the value that is inserted there

DanVanAtta commented 2 years ago

We could just remove it?

On Wed, Mar 30, 2022, 6:59 PM RoiEX @.***> wrote:

@DanVanAtta https://github.com/DanVanAtta well the tag is defined here:

https://github.com/triplea-game/triplea-game.github.io/blob/69e6873a79c8a9604c72c59a9776fa5422fe4cde/_includes/head.html#L10

Because Jekyll listens on localhost:4000 by default that's the value that is inserted there

— Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea-game.github.io/issues/348#issuecomment-1083983868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6SZOO4KLDAACBRCWBJCBDVCUBGFANCNFSM4NDDJDQQ . You are receiving this because you were mentioned.Message ID: @.***>

RoiEXLab commented 2 years ago

Well it's meta information, so yes. I assume it was originally inserted by some template or in order to improve SEO, not sure if it helps with the latter

DanVanAtta commented 2 months ago

It looks like the canonical link is fixed now on the website:

The rendered HTML source has: image

I don't know when this was fixed, it looks like the same 'meta' line is in the source code as it has been.

@tvleavitt please give a holler if you see it differently somewhere else