search

triplea-game / triplea-game.github.io

TripleA Website
https://triplea-game.org/
GNU Affero General Public License v3.0
12 stars 16 forks source link

Increase readability of list items in footer. #379

Closed NathanNOSudo closed 2 months ago

NathanNOSudo commented 1 year ago

I have a suggestion to improve the site's readability. Currently the list items in the footer are pretty compacted on top of each other, adding padding or margin will increase the footer height but adding 1.3 to 1.5 em line-height to your main.css for ul > li tags substantially increase the clarity of each item as well as readability. I have Included a before screenshot and an after screenshot. If the team is ok with it, I would gladly make the change and submit a PR. Additionally I do have some down time and am willing to help with any other improvements / fixes to your site!

Current footer: old-line-height

Suggested changes: suggested-change

RoiEXLab commented 1 year ago

@NathanNOSudo Seems like a good suggestion. Feel free to open a PR 👍🏼

DanVanAtta commented 1 year ago

Agree, that helps legibility.

We should consider as well (as a follow-up) whether we want all of the video links. Some of them are pretty out of date and perhaps not even worth linking at this point.

NathanNOSudo commented 1 year ago

Will do! Sorry for the delay, I have been on vacation.

DanVanAtta commented 2 months ago

Was working on the footer, took a quick stab at this in #398