Open BeorntheBold13 opened 1 year ago
Hey @BeorntheBold13, I can try to help you.
Your map is in this github repository: https://github.com/triplea-maps/another_world
I think your account should have committer rights to it, since the history of the commits shows you've committed to it before. To check if you have access, you can look at some open pull requests (contributions by other people, including myself) and check if you see a green "Merge" button. For example on here: https://github.com/triplea-maps/another_world/pull/10
It might look something like this:
If yes, then it means you have edit access. Once we confirm that, I can guide you how to upload your changes. (You can also review the changes in the pull requests - by looking at the "Files changed" tab and click the "merge" button if you accept the changes.)
@BeorntheBold13, just wondering if you're still interested in pursuing this.
Yes, I am, just not sure how to proceed
From: asvitkine @.> Sent: Wednesday, August 30, 2023 11:02 AM To: triplea-game/triplea @.> Cc: Byron Spinks @.>; Mention @.> Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
@BeorntheBold13 https://github.com/BeorntheBold13 , just wondering if you're still interested in pursuing this.
— Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699450546 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BADEN3LGRJK2DQWFTZB24HLXX5PYJANCNFSM6AAAAAAYPDOWAU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/BADEN3NH3VF62DW6QXD7IPTXX5PYJA5CNFSM6AAAAAAYPDOWAWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTFJOHLE.gif Message ID: @. @.> >
Do you want to put it on Google drive or drop box and put a link here? I can help make it a I'll request.
On Wed, Aug 30, 2023, 12:07 PM Byron Spinks @.***> wrote:
Yes, I am, just not sure how to proceed
From: asvitkine @.> Sent: Wednesday, August 30, 2023 11:02 AM To: triplea-game/triplea @.> Cc: Byron Spinks @.>; Mention @.> Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
@BeorntheBold13 https://github.com/BeorntheBold13 , just wondering if you're still interested in pursuing this.
— Reply to this email directly, view it on GitHub < https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699450546> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/BADEN3LGRJK2DQWFTZB24HLXX5PYJANCNFSM6AAAAAAYPDOWAU> . You are receiving this because you were mentioned. < https://github.com/notifications/beacon/BADEN3NH3VF62DW6QXD7IPTXX5PYJA5CNFSM6AAAAAAYPDOWAWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTFJOHLE.gif> Message ID: @. @.> >
— Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699459682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEJ4F26N4EUBOE3G7MYQLXX5QNRANCNFSM6AAAAAAYPDOWAU . You are receiving this because you were assigned.Message ID: @.***>
It is already on google drive, a folder named Another_World. Here is the link:
https://drive.google.com/drive/folders/1BmwPiPgDClLUwL3ERSQduK5D42x-6tCv?usp=sharing
From: asvitkine @.> Sent: Wednesday, August 30, 2023 3:22 PM To: triplea-game/triplea @.> Cc: Byron Spinks @.>; Mention @.> Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
Do you want to put it on Google drive or drop box and put a link here? I can help make it a I'll request.
On Wed, Aug 30, 2023, 12:07 PM Byron Spinks @. <mailto:@.> > wrote:
Yes, I am, just not sure how to proceed
From: asvitkine @. <mailto:@.> > Sent: Wednesday, August 30, 2023 11:02 AM To: triplea-game/triplea @. <mailto:@.> > Cc: Byron Spinks @. <mailto:@.> >; Mention @. <mailto:@.> > Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
@BeorntheBold13 https://github.com/BeorntheBold13 , just wondering if you're still interested in pursuing this.
— Reply to this email directly, view it on GitHub < https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699450546> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/BADEN3LGRJK2DQWFTZB24HLXX5PYJANCNFSM6AAAAAAYPDOWAU> . You are receiving this because you were mentioned. < https://github.com/notifications/beacon/BADEN3NH3VF62DW6QXD7IPTXX5PYJA5CNFSM6AAAAAAYPDOWAWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTFJOHLE.gif> Message ID: @. <mailto:@.> @. <mailto:@.> > >
— Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699459682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEJ4F26N4EUBOE3G7MYQLXX5QNRANCNFSM6AAAAAAYPDOWAU . You are receiving this because you were assigned.Message ID: @. <mailto:@.> >
— Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699785781 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BADEN3LM3O77UQQ5UADRFETXX6OHVANCNFSM6AAAAAAYPDOWAU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/BADEN3I34R6U4SOHP3YSWRDXX6OHVA5CNFSM6AAAAAAYPDOWAWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTFKCWDK.gif Message ID: @. @.> >
Thanks. I'm looking how to land the changes.
I notice there's a bunch of image file changes including a bunch of files that seem unnecessary for this map, like "another_world/map/flags/Extra Flags/Denmark-Norway_large.png". Norway isn't part of the map, so its images shouldn't be there.
Can you see if you can clean up the folder to remove unnecessary things?
On Wed, Aug 30, 2023 at 4:36 PM Byron Spinks @.***> wrote:
It is already on google drive, a folder named Another_World. Here is the link:
https://drive.google.com/drive/folders/1BmwPiPgDClLUwL3ERSQduK5D42x-6tCv?usp=sharing
- Byron
From: asvitkine @.> Sent: Wednesday, August 30, 2023 3:22 PM To: triplea-game/triplea @.> Cc: Byron Spinks @.>; Mention @.> Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
Do you want to put it on Google drive or drop box and put a link here? I can help make it a I'll request.
On Wed, Aug 30, 2023, 12:07 PM Byron Spinks @. <mailto:@.>
wrote:
Yes, I am, just not sure how to proceed
From: asvitkine @. <mailto:@.> > Sent: Wednesday, August 30, 2023 11:02 AM To: triplea-game/triplea @. <mailto:@.> > Cc: Byron Spinks @. <mailto:@.> >; Mention @. <mailto:@.> > Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
@BeorntheBold13 https://github.com/BeorntheBold13 , just wondering if you're still interested in pursuing this.
— Reply to this email directly, view it on GitHub <
https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699450546>
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/BADEN3LGRJK2DQWFTZB24HLXX5PYJANCNFSM6AAAAAAYPDOWAU>
. You are receiving this because you were mentioned. <
Message ID: @. <mailto:@.> @. <mailto:@.>
— Reply to this email directly, view it on GitHub < https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699459682>,
or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAEJ4F26N4EUBOE3G7MYQLXX5QNRANCNFSM6AAAAAAYPDOWAU>
. You are receiving this because you were assigned.Message ID: @. <mailto:@.> >
— Reply to this email directly, view it on GitHub < https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699785781> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/BADEN3LM3O77UQQ5UADRFETXX6OHVANCNFSM6AAAAAAYPDOWAU> . You are receiving this because you were mentioned. < https://github.com/notifications/beacon/BADEN3I34R6U4SOHP3YSWRDXX6OHVA5CNFSM6AAAAAAYPDOWAWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTFKCWDK.gif> Message ID: @. @.> >
— Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699803974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEJ4G3QAWUICHK4NQJNADXX6P53ANCNFSM6AAAAAAYPDOWAU . You are receiving this because you were assigned.Message ID: @.***>
I’ll take a look at it as soon as I can; I know I had a bunch of stuff for future ideas.
From: asvitkine @.> Sent: Wednesday, August 30, 2023 6:05 PM To: triplea-game/triplea @.> Cc: Byron Spinks @.>; Mention @.> Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
Thanks. I'm looking how to land the changes.
I notice there's a bunch of image file changes including a bunch of files that seem unnecessary for this map, like "another_world/map/flags/Extra Flags/Denmark-Norway_large.png". Norway isn't part of the map, so its images shouldn't be there.
Can you see if you can clean up the folder to remove unnecessary things?
On Wed, Aug 30, 2023 at 4:36 PM Byron Spinks @. <mailto:@.> > wrote:
It is already on google drive, a folder named Another_World. Here is the link:
https://drive.google.com/drive/folders/1BmwPiPgDClLUwL3ERSQduK5D42x-6tCv?usp=sharing
- Byron
From: asvitkine @. <mailto:@.> > Sent: Wednesday, August 30, 2023 3:22 PM To: triplea-game/triplea @. <mailto:@.> > Cc: Byron Spinks @. <mailto:@.> >; Mention @. <mailto:@.> > Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
Do you want to put it on Google drive or drop box and put a link here? I can help make it a I'll request.
On Wed, Aug 30, 2023, 12:07 PM Byron Spinks @. <mailto:@.> mailto:***@***.***
wrote:
Yes, I am, just not sure how to proceed
From: asvitkine @. <mailto:@.> mailto:***@***.*** > Sent: Wednesday, August 30, 2023 11:02 AM To: triplea-game/triplea @. <mailto:@.> mailto:***@***.*** > Cc: Byron Spinks @. <mailto:@.> mailto:***@***.*** >; Mention @. <mailto:@.> mailto:***@***.*** > Subject: Re: [triplea-game/triplea] I have made some changes to my map - another_world (Issue #11649)
@BeorntheBold13 https://github.com/BeorntheBold13 , just wondering if you're still interested in pursuing this.
— Reply to this email directly, view it on GitHub <
https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699450546>
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/BADEN3LGRJK2DQWFTZB24HLXX5PYJANCNFSM6AAAAAAYPDOWAU>
. You are receiving this because you were mentioned. <
Message ID: @. <mailto:@.> mailto:***@***.*** @. <mailto:@.> mailto:***@***.***
— Reply to this email directly, view it on GitHub < https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699459682>,
or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAEJ4F26N4EUBOE3G7MYQLXX5QNRANCNFSM6AAAAAAYPDOWAU>
. You are receiving this because you were assigned.Message ID: @. <mailto:@.> mailto:***@***.*** >
— Reply to this email directly, view it on GitHub < https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699785781> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/BADEN3LM3O77UQQ5UADRFETXX6OHVANCNFSM6AAAAAAYPDOWAU> . You are receiving this because you were mentioned. < https://github.com/notifications/beacon/BADEN3I34R6U4SOHP3YSWRDXX6OHVA5CNFSM6AAAAAAYPDOWAWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTFKCWDK.gif> Message ID: @. <mailto:@.> @. <mailto:@.> > >
— Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699803974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEJ4G3QAWUICHK4NQJNADXX6P53ANCNFSM6AAAAAAYPDOWAU . You are receiving this because you were assigned.Message ID: @. <mailto:@.> >
— Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/11649#issuecomment-1699966584 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BADEN3IU2PEDJ2BGSWUNSODXX7BLHANCNFSM6AAAAAAYPDOWAU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/BADEN3PW2R5J4H7MMXLQUW3XX7BLHA5CNFSM6AAAAAAYPDOWAWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTFKNXHQ.gif Message ID: @. @.> >
I created my own repository and made changes to the map I made 5-6 years ago called "another_world". I have no idea how to make the new files available to replace the ones currently available for download.
After a long break from the game I'm back and intend to actively implement more changes. I'm a total noob with github.
The changes are a little bit cosmetic and fixes to a couple of problems I found when playing the game with a friend - preventing a couple of exploits.
Please someone tell me what to do to get these files to the right place.