search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.34k stars 395 forks source link

dropwizard and ch.qos.logback are stuck on old versions #11865

Open asvitkine opened 1 year ago

asvitkine commented 1 year ago

dropwizard and ch.qos.logback are currently stuck on old versions.

We're using dropwizard 2.*, while upstream is on 4.*. Our logback is on 1.2.* while upstream is on 1.4.*. They probably need to be updated together, since dropwizard 2.* that we're on depends on logback 1.2.* functionality that's been removed in old versions.

For reference, here are some PRs that fail tests to bump them: https://github.com/triplea-game/triplea/pull/11705 https://github.com/triplea-game/triplea/pull/11863

Logback fails due to dropwizard needing classes that were removed: https://github.com/triplea-game/triplea/pull/11863#issuecomment-1668676740

dropwizard fails in part because there are some package name changes, so a lot of code doesn't compile: https://github.com/triplea-game/triplea/pull/11705#issuecomment-1670585526

asvitkine commented 1 year ago

@DanVanAtta

Seems like our spitfire server needs some love as a lot of its deps rolls cause test failures. So someone needs to take some time to bring us up to date with our deps. I think this is an area you have the most familiarity with?

I also wonder if we should split the server repo off the main engine repo, since right now it's unclear what needs what deps and I think all the broken deps rolls are mostly about the servers.