Restore error message and prompt to download a map when not found.

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.

https://triplea-game.org/

GNU General Public License v3.0

1.3k stars 387 forks source link

Restore error message and prompt to download a map when not found. #12586

Closed asvitkine closed 2 months ago

asvitkine commented 2 months ago

Fixes: https://github.com/triplea-game/triplea/issues/10523

Tested by trying to open a save game on a map I don't have.

Also some minor refactoring in related code to make the flow easier to understand.

Notes to Reviewer

DanVanAtta commented 2 months ago

@asvitkine I recall there being an issue with the "would you like to download" prompt being double prompted. Perhaps worth double checking that (1) joining a bot with a game in progress does not have that issue, and (2) similarly, starting a new bot game without a map also does not lead to a double prompt