search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.29k stars 382 forks source link

Update triplea_maps.yaml - v1.4 the_shogun #12622

Closed TheDog-GH closed 1 month ago

TheDog-GH commented 1 month ago

Notes to Reviewer

beelee1 commented 1 month ago

@TheDog-GH I will add it but I thought 2.6 doesn't use the yaml anymore. I haven't tried using it for any map updates. Maybe it auto does it when you update the repo ? Idk :) will have to check it out.

This will work for people on older versions though :)

beelee1 commented 1 month ago

@TheDog-GH yea as @asvitkine pointed out, only whole numbers work for the version change. I didn't look at it, just saw it was good to go. The only changes are usually just the number. Maybe the description.

Be good to have a catch for that though. I will look at the version number in the future before merging.

Last thing I want todo is create more work :)

TheDog-GH commented 1 month ago

Thanks both!