triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.

https://triplea-game.org/

GNU General Public License v3.0

1.29k stars 381 forks source link

2.6 Do not display player in Politics Table, List of players not to show (1of 4) #12636

Open TheDog-GH opened 3 weeks ago

TheDog-GH commented 3 weeks ago

Mapmakers sometimes use dummy players to achieve conditions and triggers like natural disasters/weather of just a special type of Neutral and as the true player cannot interact with them they should not be displayed, to reduce confusion.

This could be a list of Players.

Project Feature Cards https://github.com/orgs/triplea-game/projects/9/views/1

EDIT: As per Cernelius suggestion below this should be in map.properties

WCSumpton commented 3 weeks ago

There is the "isHidden" option of the which is used to not show this player on the select screen. Could this option be expanded to cover Politics, Tech, Player, etc. Or is there some other idea on how to accomplish this. (This can reference #12635 also.)

Cheers...

TheDog-GH commented 3 weeks ago

@WCSumpton Yes that would work.

I had initially thought it would be a special 'Property' of sorts, with a list of Players that are not shown.

I dont know what would be best

Project Feature Cards https://github.com/orgs/triplea-game/projects/9/views/1

Cernelius commented 3 weeks ago

There is the "isHidden" option of the which is used to not show this player on the select screen. Could this option be expanded to cover Politics, Tech, Player, etc. Or is there some other idea on how to accomplish this. (This can reference #12635 also.)

So long as this is not impacting on the rules, I think it belongs to the skin.

To clarify, the "isHidden" option actually has game relevance in that it makes impossible to assign that player. Here, instead, it looks like it is merely a display matter, so it should be handled at a skin level like the map.property "dont_draw_units".

Cernelius commented 3 weeks ago

Same as above for https://github.com/triplea-game/triplea/issues/12635

TheDog-GH commented 3 weeks ago

As there are 4 very similar requests they hopefully will all be actioned at the same time? This one and

12645

12635

12646

so in the map.properties we could have the following?

# On the Politics panel Ctrl+W Do Not Show the following player/factions
# player.doNotShowInPoliticsTable=Gaia:Neutral:none

# On the Players tab Do Not Show the following player/factions
# player.doNotShowInPlayerTable=Gaia:Neutral:none

# On the Players tab, Tech Table Do Not Show the following player/factions
# player.doNotShowInTechTable=Gaia:Neutral:none

# On the Help> Unit help table Do Not Show the following player/factions (Note NULL)
# player.doNotShowInUnitHelp=Gaia:Neutral:none:NULL

Thoughts?

EDIT Added 4th entry

Cernelius commented 3 weeks ago

Maybe better having a single one for not showing it in Politics, Players and Tech table alike?

Substantially, TripleA is already doing this for the "Neutral" player, so it may be just an option telling the program to treat the players just like the "Neutral" player is currently already treated in any such matters. It could be a list of players thus hidden, with the default being "Neutral" only (if not specified).