triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.3k stars 387 forks source link

Fix logic for damage units selection for 3hp units. #12685

Closed asvitkine closed 2 weeks ago

asvitkine commented 2 weeks ago

Previously logic was not working correctly and was overriding the user's selection in terms of how many units should take 2hp of damage vs. 1hp.

Adds a test. Also improves/adds some comments on the existing logic. Fixes: https://github.com/triplea-game/triplea/issues/12672

Notes to Reviewer