Bots do not reset to launch screen on exit

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.

https://triplea-game.org/

GNU General Public License v3.0

1.34k stars 393 forks source link

Bots do not reset to launch screen on exit #12732

Closed DanVanAtta closed 2 months ago

DanVanAtta commented 2 months ago

Reproduction Steps

join a 2.6 bot
select all seats, wait for game to launch
exit game
rejoin game
notice: game is not ended, if rejoined - the in-progress game is joined.

Quite a problem since there is no to end a game on a bot once started.

DanVanAtta commented 2 months ago

I'm thinking we can add a flag to bots "exit on end", when true - the bot would shut down when the game ends. We can then rely on systemctl to restart the service.

Benefits:

maps would be reloaded between games since the bot is restarted
maybe can mitigate any memory leaks and such issues

Drawbacks:

the underlying problem is not really fixed and could pose an issue for those who are running bots without systemctl

DanVanAtta commented 2 months ago

Workaround with 'exit on end' now implemented & deployed to 2.6 lobby

DanVanAtta commented 2 months ago

No longer able to repro...