search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.34k stars 393 forks source link

install4j - make the JRE dynamically optionally bundled #354

Closed DanVanAtta closed 8 years ago

DanVanAtta commented 8 years ago

"JRE is downloaded at installation start if there are no good Java installed for the user. " #260

This is needed for the next release, hence the 'urgent' label.

DanVanAtta commented 8 years ago

@gaborbernat , will you be able to get this done before the next release (next few weeks/month)?

Please submit a PR for any bundled JREs that will be needed to be available to this repo: https://github.com/triplea-game/assets. Reflecting on prior conversation and in light that Java8 provides stripped down JREs, I trust your judgement to make a good choice.

@gaborbernat , I'd like us to have a last final push in the coming weeks to get all of the installer/build issues wrapped up and taken care of.

gaborbernat commented 8 years ago

will work on this today/tomorrow :+1: so probably yes; will see how it goes

DanVanAtta commented 8 years ago

I updated the travis+install4j configs for the updated JRE names @gaborbernat . Once I confirm they are working, I'll leave the rest of the updates to you. Apologies for the merge conflict if you get any, please rebase to latest master. Thanks and good luck

DanVanAtta commented 8 years ago

376 will resolve this.