search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.34k stars 393 forks source link

Install4j Dynamic JRE Bundle - Will it Upgrade JRE? #4699

Closed DanVanAtta closed 5 years ago

DanVanAtta commented 5 years ago

We need to understand better how install4j dynamic JRE bundles handle upgrades.

A dynamic JRE bundle is where we have a 20MB installer that detects if a suitable JRE is installed and if not it downloads a ~30MB JRE that is used to launch TripleA. In contrast we could configure a 'static' bundle that always has a ~30MB JRE installed.

Question: Will dynamic non-shared bundle upgrade to a new java version?

To answer, we need a windows and/or mac user to remove both Java and TripleA from their OS, and then install TripleA with (dynamic non-shared) Java-8 using this installer:

Then launch the game, verify it says it is using Java8. Next, install with the java-11 installer below and then verify that the game launches and reports Java 11:

/cc: @tvleavitt

tvleavitt commented 5 years ago

I can do this, timeline would be Weds. evening at the earliest, however.

Thomas Leavitt

On Tue, Feb 19, 2019, 10:32 AM Dan Van Atta <notifications@github.com wrote:

We need to understand better how install4j dynamic JRE bundles handle upgrades.

A dynamic JRE bundle is where we have a 20MB installer that detects if a suitable JRE is installed and if not it downloads a ~30MB JRE that is used to launch TripleA. In contrast we could configure a 'static' bundle that always has a ~30MB JRE installed. Question: Will dynamic non-shared bundle upgrade to a new java version?

To answer, we need a windows and/or mac user to remove both Java and TripleA from their OS, and then install TripleA with (dynamic non-shared) Java-8 using this installer:

- https://github.com/triplea-game/triplea/files/2873961/windows-64-java-8.zip

Then launch the game, verify it says it is using Java8. Next, install with the java-11 installer below and then verify that the game launches and reports Java 11:

- https://github.com/triplea-game/triplea/files/2873939/windows-64-java-11.zip

/cc: @tvleavitt https://github.com/tvleavitt

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/4699, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPTgXsQ08X3ktR5UsthF0nR7HxJdmi1ks5vPEM9gaJpZM4bDmP0 .

DanVanAtta commented 5 years ago

https://github.com/triplea-game/triplea/pull/4876 adds bundled JRE installer

@tvleavitt if you're able, the latest pre-release has java 11 with bundle.

tvleavitt commented 5 years ago

No dice on the bundled Java for OS X. Caveat: it detected a previous install, which used a separate external JDK installation which I nuked prior to installing this. Not sure how the installer handles that?

Thomas

On Mon, Jun 10, 2019 at 3:28 PM Dan Van Atta notifications@github.com wrote:

4876 https://github.com/triplea-game/triplea/pull/4876 adds bundled

JRE installer

@tvleavitt https://github.com/tvleavitt if you're able, the latest pre-release has java 11 with bundle.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/4699?email_source=notifications&email_token=ABB5HAPCTM5YRC5FYEWOXHTPZ3IRJA5CNFSM4GYOMP2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLNFLA#issuecomment-500617900, or mute the thread https://github.com/notifications/unsubscribe-auth/ABB5HAKS34TMXJTETAHIPO3PZ3IRJANCNFSM4GYOMP2A .

-- Thomas Leavitt Internet enabled since 1990

DanVanAtta commented 5 years ago

Oy, sounds like then there is not much point to bundle a JRE with the mac installer then. The conditional download if no JRE is detected is probably worthwhile still, but seems we can't rely on the bundled JRE always getting picked up.

Thanks for testing @tvleavitt

I think this lends further reason to give JMOD a try (https://github.com/triplea-game/triplea/issues/4893) rather than an install4j installer.

I'm going to re-open this issue so we have better tracking. I think one more next step we can do is to reach out to install4j and see if they have a recommendation or a script reference that can help 'force' the right JRE to be used.

tvleavitt commented 5 years ago

Glad I could help.

I'll try and get to the Windows version in a VM this weekend.

Thomas

On Thu, Jun 13, 2019 at 5:49 PM Dan Van Atta notifications@github.com wrote:

Oy, sounds like then there is not much point to bundle a JRE with the mac installer then. The conditional download if no JRE is detected is probably worthwhile still, but seems we can't rely on the bundled JRE always getting picked up.

Thanks for testing @tvleavitt https://github.com/tvleavitt

I think this lends further reason to give JMOD a try (#4893 https://github.com/triplea-game/triplea/issues/4893) rather than an install4j installer.

I'm going to re-open this issue so we have better tracking. I think one more next step we can do is to reach out to install4j and see if they have a recommendation or a script reference that can help 'force' the right JRE to be used.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/4699?email_source=notifications&email_token=ABB5HAJ3XHW2QRRRC5L6T5TP2LTH7A5CNFSM4GYOMP2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXVNDLI#issuecomment-501928365, or mute the thread https://github.com/notifications/unsubscribe-auth/ABB5HAO7434NEGZ6MLSYXBTP2LTH7ANCNFSM4GYOMP2A .

-- Thomas Leavitt Internet enabled since 1990

DanVanAtta commented 5 years ago

It seems like this question is answered. I suspect we will want a feature in TripleA to detect java version and if the version being used is old. In that case we could prompt and warn the user to upgrade.