search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.32k stars 392 forks source link

Submarine submerge and retreat issues #4821

Open panther2 opened 5 years ago

panther2 commented 5 years ago

Tested with 1.10.14614

I am very short of time at the moment so this is more or less an announcement of possible issues that have to be deeper investigated for all map-versions. While testing https://github.com/triplea-game/triplea/pull/4820 and taking a quick glance on some other versions I noticed this:

First issue: When the attacker chooses to submerge TripleA submerges all attacking submarines. Instead the attacker should be able to choose how many of his subs should submerge. Also the defender should be able to select how many of his subs should submerge,

Second issue: When the attacker chooses to retreat (to an adjacent space) submerged subs are retreated together with the other ships. Instead the submerged subs should remain in the contested seazone.

I am sorry for this "unprofessional" report, but as I said, I don't have much time right now. So any help in investigating possible differences in rulesets and testing the respective implementation in TripleA is highly welcome.

CC: @ron-murhammer

ron-murhammer commented 5 years ago

@panther2 Interesting. I didn't realize you could choose to submerge only specific subs. I figured it was like retreating units which is all or nothing. Are there certain scenarios you can think of that you'd want to submerge only some subs?

panther2 commented 5 years ago

@ron-murhammer Yes there are, Sometimes you want to leave (one or more) submerged submarines in the contested seazone. When they resurface the opponents have to deal with them in any way. At the same time you maybe want to retreat your (non submerged) subs together with the fleet to an adjacent space. Or you want to submerge (some) and continue the battle with the rest of the units.

Some rulesets explicitly state "submerge any number of subs" while no ruleset explicitly demands "submerge all subs". Also submerged subs should not been moved with the retreating fleet.

When I have some more time, I will check the engine and the rules map version by map version (ruleset by ruleset) concerning these issues. I just can't do it these days.

trevan commented 4 years ago

I have a fix for the second issue in #7007