search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.32k stars 392 forks source link

Min Java Version Warning Feature #4935

Open DanVanAtta opened 5 years ago

DanVanAtta commented 5 years ago

Following up on some problems we had with old java versions, I think we want a feature to detect java version, find a min java version, and warn the user if they should upgrade their java version.

Follows up on:

I think we could perhaps do this by updating latest_version.properties, or lobby_server.yaml to include a min java version. I suspect we would need to indicate the min version by OS. After we have that, we can update the game engine to read this info and compare against the current running.

While at it, I suspect we could combine these two files as well to simplify the network fetch and game logic.

Any thoughts on this?

RoiEXLab commented 5 years ago

But doesn't having a fixed JRE bundled with the installer make this all redundant?

DanVanAtta commented 5 years ago

Seems no, see #4699, if I understand right, Mac will not necessarily use the bundled JRE.

RoiEXLab commented 5 years ago

Bummer. I feel like there has to be a way though :(

stale[bot] commented 4 years ago

The TripleA team regrets this issue was not solved sooner. To keep focus on latest issues and the most pressing tasks, this issue has been automatically marked as stale because it has not had recent activity. If the issue may be closed, please do so. If there are remaining items, we encourage for those items to be resubmitted as new, independent, concise tasks. The strategy is divide and conquer. Thank you for your contributions.