search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.34k stars 393 forks source link

Travis build script should terminiate with error if installers are not created #5395

Closed panther2 closed 4 years ago

panther2 commented 4 years ago

See https://github.com/triplea-game/triplea/releases/tag/2.0.16345

DanVanAtta commented 4 years ago

Looks like a one-time problem where install4j was unable to download network resources, presumably the bundled JDK.

One issue of note is that the overall build did not fail, we should update this portion of the travis build script to not continue and to instead kill the travis build with an error code.

install4j: compilation failed. Reason: java.net.SocketTimeoutException: Read timed out
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':game-headed:platformInstallers'.
> Process 'command '/bin/sh'' finished with non-zero exit value 1

The command "./.travis/do_release" exited with 0.

I'll re-run this build and with luck this is a very temporary problem. If so, this is a good tracking ticket to fix the error reporting so that we can more pro-actively know about this going forward.

panther2 commented 4 years ago

Allright, looks good now. Thanks!

panther2 commented 4 years ago

@DanVanAtta It happened again with https://github.com/triplea-game/triplea/releases/tag/2.0.16450 No need to rebuild, as there are so many open PR. Just to let you know.