triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.33k stars 392 forks source link

[Urgent] Bots unable to load WW_II_Revised saves #6774

Closed DanVanAtta closed 4 years ago

DanVanAtta commented 4 years ago

How can the problem be recreated?

If reproduced, game load should do roughly nothing and observe the following in logs:

Jun 23 19:56:22 li1116-193 run_server[2853509]: INFO: Changed to game map: World War II Revised
Jun 23 19:56:26 li1116-193 run_server[2853509]: INFO: Game mapName not in available games listing: world_war_ii_revised

Do you have any ideas for an expected fix?

Attach a Save Game

If playing a prerelease, which version are you using?

Game Version:

If playing a prerelease, does this happen on the latest release?

Is there anything else we should know?

DanVanAtta commented 4 years ago

Custom deployed v2.0.20193 to a bot in prod2 and could not reproduce this problem... :anguished:

DanVanAtta commented 4 years ago

This will perhaps simply be fixed by deploying latest to all bots. I learned in this we should have confidence/faith in the prerelease bot and be sure to use that for our "what happens with the latest version" testing that we want to be actually deployed out. FWIW, local, prerelease, and the test server in prod all on latest were consistently behaved.

The 'thing' that is impacting bots on 2.0.20183 causing save game to not load is mysterious. This is also a place where error handling from bot to user could be better, the save game fails to load silently.

DanVanAtta commented 4 years ago

Deployed a 2.0.20193 to prod bot 02; hit the same error!

DanVanAtta commented 4 years ago

With some more debugging, the situation is expected. Why, hard to say.

The list of available games does not include "world_war_ii_revised", but we do parse the map zip for it:

Jun 24 06:48:01 li1232-106 run_server[2989014]: INFO: Loading map: /home/bot/maps/world_war_ii_revised-master.zip

INFO: Done loading maps, availableMapFolderOrZipNames count: 137, contents: [age_of_tribes-master, greyhawk-master, ww2v3_11n-master, charles_de_gau lle_1939-master, iron_war_europe-master, command_and_conquer-master, operation_market_garden-master, battle_for_arda-master, middle_east-master, ww2v3_variants-master, sengoku_jidai-master, new_wo rld_order-master, twilight_imperium-master, d-day-master, fallen_empire-master, world_war_ii_revised_variations-master, diplomacy-master, arnhem-master, caribbean_trade_war-master, big_world-maste r, ultimate_world_variants-master, roman_invasion-master, feudal_japan-master, camp_david-master, great_lakes_war-master, elemental_forces-master, cold_war_1965-master, age_of_the_sturlungs-master , ur_quan_war_masters_edition-master, the_pact_of_steel-master, world_war_ii_v4-master, large_middle_earth-master, a_song_of_ice_and_fire-master, civil_war-master, small_balanced_2_or_4_player-mas ter, 270bc_variants-master, global_1940_redesign_house_rules-master, classic_variations-master, aa_enhanced_revised-master, conquest_of_the_world-master, domination_1914-weltpolitik-master, neusch wabenland-master, feudal_japan_warlords-master, alagaesia-master, 1914-cow-empires-master, the_rising_sun-master, steampunk-master, hex_globe10-master, tactics_campaign-master, steampunk_advanced- master, empire-master, global_40_house_rules-master, domination-master, peninsula_campaign-master, invasion_usa-master, blue_vs_gray-master, battle_of_aventurica-master, atari-master, world_war201 0-master, world_war_ii_v3-master, map_making_tutorial-master, new_world_order_variants-master, war_of_the_relics-master, new_world_order_lebowski_edition-master, cybertank-master, stalingrad-maste r, world_at_war-master, minimap-master, ultimate_world-master, the_grand_war-master, big_world_variations-master, game_of_thrones-master, crazygs_ww1-master, star_wars_tatooine_war-master, zombiel and-master, world_war_ii_global-master, domination_1914_blood_and_steel-master, war_of_the_lance-master, new_world_order1915lebowski-master, stellar_forces-master, world_war_ii_v5_1942-master, iro n_war-master, dragon_war-master, domination_1914_no_mans_land-master, nwo_variants-master, great_war-master, house_of_habsburg-master, napoleonic_empires-master, star_trek_dilithium_war-master, ca ravan-master, eastern_front-master, 270bc-master, world_war_ii_v6_1941-master, first_punic_war-master, tutorial-master, blood_and_iron-master, tiberian_conquest_eu-master, 1941-master, world_war_i i_pacific-master, the_rising_sun_variants-master, total_world_war-master, oztea_1939_global-master, ww2_phillipines-master, europe-master, red_sun_over_china-master, pacific_challenge-master, paci fic-master, warcraft_war_heroes-master, global_war-master, big_world_2-master, ww2_path_to_victory-master, ancient_times-master, pact_of_steel_variations-master, world_war_ii_classic-master, cold_war-master, world_war_ii_europe-master, schultz_european_war-master, twelve-clans-master, cold_war_asia1948-master, rome_total_war-master, global_war2-master, greyhawk_wars-master, jurassic-master, total_ancient_war-master, oztea_1942-master, star_wars_galactic_war-master, sleeping_giant-master, world_at_war_variants-master, tiberian_conquest_au-master, tiberian_conquest_sa-master, pacific_1942-master, battle_of_jutland-master, middle_earth-master, the_great_northern_war-master, another_world-master, d-day2-master, capture_the_flag-master];

DanVanAtta commented 4 years ago

Deployed the latest patch (#6834) to bot servers, and am now no longer able to repro this problem.