DanVanAtta
commented
4 years ago Let's use this issue to resolve the duplicate map/game names.
cc: @Cernelius, @ZjelcoP
Open DanVanAtta opened 4 years ago
DanVanAtta
commented
4 years ago Let's use this issue to resolve the duplicate map/game names.
cc: @Cernelius, @ZjelcoP
tvleavitt
commented
4 years ago Why does the data structure ignore the leading pathname parts? That would assure a unique name, and make filename collisions between different "Maps" irrelevant.
tvleavitt
commented
4 years ago You could solve the UI interface problem of duplicate Game names (a different issue) by a nested structure the showed Maps, and then Games associated with them when expanded (while offering an "Expand All" option that would allow people to see all Games on all Maps at once, albeit scrolling might be required). This would also help clarify for end-users the link between the "Map" they just downloaded, and the new "Games" showing up in the list.
DanVanAtta
commented
4 years ago "Maps" are not in a human friendly format. Once we make the map tag not required anymore, it'll be a map folder and the game perhaps will be more aptly named a map. Regardless fully qualified is an idea though would probably be largely redundant as most "games" match their map name
On Thu, Jul 9, 2020, 7:21 PM Thomas Leavitt notifications@github.com wrote:
You could solve the UI interface problem of duplicate Game names (a different issue) by a nested structure the showed Maps, and then Games associated with them when expanded (while offering an "Expand All" option that would allow people to see all Games on all Maps at once, albeit scrolling might be required). This would also help clarify for end-users the link between the "Map" they just downloaded, and the new "Games" showing up in the list.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/triplea-game/triplea/issues/7089#issuecomment-656443740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6SZOII24TRLJ7ICMKF7N3R2Z3LFANCNFSM4OWECHQQ .
ZjelcoP
commented
4 years ago Ah haven't seen those in a long time! I never uploaded these maps myself so didn't have any control of how they were organised or combined. No deliberate choices from my side.
D-day was created by Dagon81 but is basically a good graphical map copy of the original board game but without any special rules, just put the units on the board. From notes: Allies must capture all 3 cities to win. Germans win by preventing their capture for 20 turns, or something like that. I don't really know this map Didn't have much play value as such. Now the map somehow uses the maptiles form D-day 2 making it completely useless in my view.
D-Day 2 ended up more as a personal challenge to see how far i could stretch TripleA to be able to play the very unusual rules of this original boardgame. Result is full of maphacks and player enforced rules. Also not much play value unless you really want to play this specific map online.
TripleA and it's options have evolved a lot since then so probably it is possible to make it fairly playable at this point though requiring a complete rebuild and lot's of advanced mapmaking knowledge and tricks.
I'd say: 1)-Archive the D-day map with version 2.1 of D-day 2 in it. It would be good to keep the original mapfiles around as a resource for future rework as it is an originally published boardgame version. Just not show it in the download/play section.
2)-Keep the D-day 2 map around in experimental as it is exactly that. Someone that knows the original might actually want to play it. Others might be triggered with ideas by the strange rules and the map-hacks or lacking implementation of current possibilities.
Cernelius
commented
4 years ago I'd say: 1)-Archive the D-day map with version 2.1 of D-day 2 in it. It would be good to keep the original mapfiles around as a resource for future rework as it is an originally published boardgame version. Just not show it in the download/play section.
2)-Keep the D-day 2 map around in experimental as it is exactly that. Someone that knows the original might actually want to play it. Others might be triggered with ideas by the strange rules and the map-hacks or lacking implementation of current possibilities.
This seems the best solution to me too, but, in this case, I suggest renaming the "D-Day 2" map and game to just "D-Day", instead of "D-Day 2". If users see a game called "D-Day 2", they will expect also to see a game called "D-Day". The regular "D-Day" can, then, remain archived as the old version of the same named map.
Cernelius
commented
4 years ago D-day was created by Dagon81 but is basically a good graphical map copy of the original board game
How good? If it is too good at that and the original is copyrighted, I guess it would have to be deleted... (I'm sorry to say and never played or seen the original)
stale[bot]
commented
4 years ago This issue has been automatically marked as stale because it has not had recent activity. If there is something that can be done to resolve this issue, please add a comment indicating what that would be and this issue will be re-opened. If there are multiple items that can be completed independently, we encourage you to use the "reference in new issue" option next to any outstanding comment so that we may divide and conquer.
@Cernelius said in https://github.com/triplea-game/triplea/issues/7005#issuecomment-656354395_:
Ok, terminology aside (@tvleavitt the "map" folder you download is the map and, as far as I know, it has always officially be known as such, if it is not a mapskin and since skin-less maps (practically, collections of mods) have ceased being offered (since after GitHub times, the map is inside another "master" folder, but the old format is still supported too)), if what @tvleavitt says is correct (summarizing, the problem is that the "games" folder's XML file names are the same), I think the problems here are twice and partially different, and are mainly problems at a map level. We can say that, if in the past this was not a problem for the program, then the program had the problem of ignoring such problems.
In this case, also the game names are the same, specifically, as you can see in the Select a Game window you get two games both called "D-Day 2":
And:
These games are both offered as "D-Day 2" in the "Games" list. This is very confusing also since, by reading through the notes for a few minutes, I've no idea what is even the difference between the two games or how any user is supposed to decide which one to pick amongst the two. It seems that there is the "d-day" map that offers what is probably, or at least assumingly, the main "D-Day" game and it also offers a modification of it called "D-Day 2". Then, there is another map called "d-day2" that offers another game called "D-Day 2". It would be good, here, to know what is the difference between the two "D-Day 2" games and if one of the two can be renamed or even deleted. In my opinion, TripleA should not accept game names that are exactly the same as existent ones, for the sake of avoiding confusion. I would suggest the main developer to make a rule that once a name is taken for a game, nobody else can have it too. If this rule would be made, then the newest one of these games should be the one to be renamed or removed, unless it can be demonstrated that the old one should better be removed (as being inferior, for some reasons). @ZjelcoP I see you are credited in both games. Why did you make both a game modification of the "D-Day" game within the "d-day" map and a map modification of the "d-day" map having its game called the same way as the aforementioned game modification, if my understanding is correct? Was one of the two supposed to be eventually deleted in favour of the other one? The first difference that I see is that the game of the map modification (the "d-day2" map) has a higher game version and a number of players equal to 6, while the game modification (within the "d-day" map) has a lower game version and a number of players equal to 5. Is maybe the "D-Day 2" game of the "d-day2" map simply the "successor" of the "D-Day 2" game of the "d-day" map? Would it be advisable to delete the older one (usually old versions are not kept around, otherwise you would have tens of games for each of several maps)?
This looks like a simple and obvious case. The game in the "world_war_ii_revised" map is the well known "World War II Revised" game, as you can see in the Select a Game window:
And the game of the "world_war_ii_revised_variations" map appears to be simply a duplicate of the same, I surmise inadvertently duplicated.
Here the obvious solution seems just to delete this file:
world_war_ii_revised_variations/map/games/ww2v2.xmlHowever, now this raises the question why am I not seeing two "World War II Revised" games in my "Games" list in the "Select a Game" window, like it happens, instead, for the two "D-Day 2" games? I think this should be indagated, as I cannot find an answer to this question.
While looking into this, I have to report that there is at least a third case, as the "world_war_ii_revised" and "world_war_ii_revised_variations" maps are both also offering what appears to be the same "World War II Revised LHTR" game, as the same named "lhtr.xml" file within each of their "games" folders.
However, now this also raises the question why is this not giving the error that the "ww2v2.xml" files are giving, instead, if it isn't?
Here the obvious solution seems just to delete this file:
world_war_ii_revised_variations/map/games/lhtr.xmlSide note, I suggest renaming the "lhtr.xml" file to something like "ww2v2_lhtr.xml".