search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.34k stars 393 forks source link

[2.2.20790]World War 2010 [1.3.0] issues #7882

Open CharlieAtlas opened 3 years ago

CharlieAtlas commented 3 years ago

This map isn't repairing correctly. I think paratroopers are also not working. I think these lines are where the repair issue is occurring. It shouldn't have the '_hit', or at least when i removed that it worked. 

    <repairRule name="repairFactory">
      <cost resource="PUs" quantity="1"/>
      <result resourceOrUnit="factory_hit" quantity="1"/>
    </repairRule>
    <repairRule name="repairFactoryIndustrialTechnology">
      <cost resource="PUs" quantity="1"/>
      <result resourceOrUnit="factory_hit" quantity="2"/>

https://forums.triplea-game.org/topic/1919/world-war-2010/

I don't have a clue how paratroopers work though.
And if someone is going to fix it, i think this map could also use slightly better victory conditions. Mainly an economic option, probably 120-130 (total map production is 195 i think). 12 VC would also be nice, and i could see 11 working as well (13 right now, and 18 total).

DanVanAtta commented 3 years ago

To help us debug more easily - would you be able to attach a zip save game at the point right before you would expect repair to happen?

CharlieAtlas commented 3 years ago

2010test.zip

This should be it. It is right before the repair phase.

CharlieAtlas commented 3 years ago

So i have been learning about Git and PRs and what not. I am pretty sure about what this problem is, so I am going to make a PR on the map in triplea-maps.

DanVanAtta commented 3 years ago

Great stuff @CharlieAtlas :+1:

CharlieAtlas commented 3 years ago

i just remembered, isn't there a yaml file somewhere that needs to get updated too? i didn't do that.

CharlieAtlas commented 3 years ago

I found the yaml i think. it says version 2. I guess that means i need to update it to version 3? I am going to do that. if it isn't correct, just ignore my PR.