search

triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.35k stars 399 forks source link

Many file problems with latest update #7918

Closed RogerCooper closed 3 months ago

RogerCooper commented 4 years ago

When opening the program I immediately receive the following error:

Unexpected error reading XML file: jar:file:/C:/Users/Roger/triplea/downloadedMaps/crazygs_ww1-master.zip!/crazygs_ww1-master/map/MovementTriggers.xml, ParseError at [row,col]:[1,1] Message: Premature end of file. javax.xml.stream.XMLStreamException: ParseError at [row,col]:[1,1] Message: Premature end of file. If this problem happens frequently and is something you cannot fix, please report it to TripleA

Also a map I was working on in unzipped form does not appear in the map selection list.

And I mod called WW2v3_Bad-Ass_4_Nation_FFA.zip appears 14 times on the selection list and will not run on any of them.

RogerCooper commented 4 years ago

This is with version 22024

FrostionAAA commented 4 years ago

At least the problem with unzipped maps not showing has been fixed with the fix in #7904 as far as I know Right, @RogerCooper?

trevan commented 4 years ago

This is caused by https://github.com/triplea-game/triplea/pull/7617. @DanVanAtta made a change to read all .xml files in any directory inside of the zip file instead of just games/map/*.xml. Your file MovementTriggers.xml ends with .xml and so it tries to parse it as a game file and fails. That's where the error messages are coming from. And I bet you have 14 xml files in your zip and the UI is showing one entry for each xml.

trevan commented 4 years ago

@RogerCooper , I just downloaded the crazygs_ww1-master in the latest pre-release and I didn't see any errors. I also checked the zip file and I don't see a MovementTriggers.xml file. Are you using a modified map?

Can you retry using the latest prerelease and see if these errors are still happening? If they are, can you upload the zips (for both maps you mentioned)?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. If there is something that can be done to resolve this issue, please add a comment indicating what that would be and this issue will be re-opened. If there are multiple items that can be completed independently, we encourage you to use the "reference in new issue" option next to any outstanding comment so that we may divide and conquer.

DanVanAtta commented 3 years ago

FWIW, this problem will be solved more systematically with the introduction of the map.yml file that will explicitly index any XML files that are to be considered game files.