search

triplea-maps / world_war_ii_global

0 stars 11 forks source link

Harbour and Airfield in India have the wrong owner #1

Closed simon33-2 closed 8 years ago

simon33-2 commented 8 years ago

The Harbour and Airfield in India should be owned by UK_Pacific, not Britain/UK_Europe

ron-murhammer commented 8 years ago

@simon33-2 Can you get some other experienced global players to verify this?

simon33-2 commented 8 years ago

I've posted a question - but there's no doubt in my mind.

panther2 commented 8 years ago

The territory owner of course is UK_Pacific. The issue here is that facility-repairs are paid by UK_Europe but instead should be paid by UK_Pacific. I think this is due to the programming approach of the "One Power, Two Economies" - status of the United Kingdom.

But this issue is already covered in the game notes:

Quote from game notes: Rules specific to 1940 the engine does not do, but you must follow: ...

panther2 commented 8 years ago

Also please see https://github.com/triplea-game/triplea/issues/1029#issuecomment-237338881

simon33-2 commented 8 years ago

Here's a diff of the fix, to the file: games/ww2global40_2nd_edition.xml (same fix for other 4 files in the games directory): 6014c6014

< 

                  <unitPlacement unitType="harbour" territory="Kwangtung" quantity="1" owner="British"/>

6017c6017

< 

                  <unitPlacement unitType="harbour" territory="Malaya" quantity="1" owner="British"/>

6027,6028c6027,6028 <

< 

                  <unitPlacement unitType="airfield" territory="India" quantity="1" owner="British"/>
                  <unitPlacement unitType="harbour" territory="India" quantity="1" owner="British"/>

I'll see if I can crack the pull request on the weekend.

panther2 commented 8 years ago

Great - so the issue was caused by the initial setup only, meaning that everything else is just working fine.

simon33-2 commented 8 years ago

This fix has been merged. Close issue