search

triplea-maps / world_war_ii_global

0 stars 11 forks source link

Fixes Vichy Bug #13

Closed simon33-2 closed 7 years ago

simon33-2 commented 7 years ago

Strange bug with triggering/not triggering Vichy incorrectly. Can't recall which way around it was.

simon33-2 commented 7 years ago

Also add maps with combat move before purchase.

Added to note about combat move with the only valid landing site to a newly purchased carrier needs an edit mode fix on these maps.

simon33-2 commented 7 years ago

@DanVanAtta @ron-murhammer Can someone merge this? Does anyone else have write access?

panther2 commented 7 years ago

In this context - can we have a decision on #9 ?

We would have 9 files inside the game-subfolder if we keep those files that are no longer needed/updated.

simon33-2 commented 7 years ago

@panther2 I've added removing those three files to this PR.

ron-murhammer commented 7 years ago

@simon33-2 @panther2 Can one of you list the changes that are being done with the PR and why? Also can you confirm you tested after making those changes.

panther2 commented 7 years ago

@ron-murhammer

Please see issue #9 to understand my point. We don't need (7 old + 2 new =) 9 game.xml files inside the game folder, because three of them are obsolete, IMHO. No need to test this as we are just removing unneeded variants.

I am not familiar with the balance mod, so I cannot comment on this. I am sure @simon33-2 will do.

simon33-2 commented 7 years ago

Hi @ron-murhammer This PR resolves an issue with the balanced mod map where Vichy is incorrectly triggered in spite of the presence in Southern France of a british land unit. (Or at least I'm told it does)

It also adds a couple of other slightly different maps (one each for 2nd ed and balanced mod) which have combat move before purchase. Finally it removes the two redundant .txt files from the game directory and the Alpha+3 map which Panther (who would know) tells us that no one plays.

Regarding testing, I have now tested it.

simon33-2 commented 7 years ago

Ok, now I've tested it. (oops, needed a change!)

simon33-2 commented 7 years ago

@ron-murhammer

ron-murhammer commented 7 years ago

@simon33-2 @panther2 Merging this. One note is that I don't want to keep adding lots of variations to the core global 40 download and if we get any more then we'll need to most likely break them of into a separate download. This tends to cause lots of confusion for newer players around what map is the core and which are variations.

Please test and make a pull request in the main repo to increment the download version number when ready.

simon33-2 commented 7 years ago

Thanks @ron-murhammer