search

triplea-maps / world_war_ii_global

0 stars 11 forks source link

Adding Ozteas 1941 xml #19

Closed beelee1 closed 7 years ago

beelee1 commented 7 years ago

Adding Ozteas 1941 setup for the global40 game. The game plays fine. Idk if I got all this pull request stuff right

simon33-2 commented 7 years ago

Objectives don't work. Can you add the relevant lines to objectives.properties? Look at some of the existing ones to figure it out. Should be reasonably obvious.

beelee1 commented 7 years ago

forgot to add the new one. Traveling.Will do in a couple days. Edit: Added Oztea to the objectives

simon33-2 commented 7 years ago

Was some problem merging README.md. Have fixed that.

I'll merge it.

simon33-2 commented 7 years ago

BTW, you also need to move on the triplea_maps.yaml in the triplea-game repo. Are you aware of this? Otherwise users won't be notified of a change when they go into Download Maps.

beelee1 commented 7 years ago

Right on simon. Don't know why the readme gave you trouble. I just added the one sentence, but it's all new to me.

Yea not familiar with the yaml program. I think I saw something about it in one of the mapmaking links. Ok think I found it. I'll give it a shot.

Yea I've been her before but the link is broken https://github.com/triplea-maps/Project/blob/master/production_config/triplea_maps.yaml Do you know what the current one is ?

beelee1 commented 7 years ago

@simon33-2 I forked a copy of the maps yaml. Do I just need a description and then do a pull request ? Don't mess with version or anything else ?