search

triplea-maps / world_war_ii_global

0 stars 11 forks source link

Remove some information from readme.md #20

Closed panther2 closed 7 years ago

panther2 commented 7 years ago

There are some more games inside this map, than only Oztea's setup. Either we list all of them or none, IMHO.

beelee1 commented 7 years ago

@panther2 I just added the oztea xml to the games folder with all the other xmls. Maybe I was supposed to just add the oztea xml ? Also do you know where triplea-game repo is ? A git search didn't turn anything up and the link at Update Triplea_maps.yaml is broken.

panther2 commented 7 years ago

@beelee1 Don't worry, it was only the oztea.xml that has been merged. It is enough to add only the files that change or are new. Indeed, there was no need to touch the readme.md (that describes the complete repo), but this is no big deal.

Here is the triplea-game repo: https://github.com/triplea-game/triplea

And this is the correct link to the Triplea-maps.yaml: https://github.com/triplea-game/triplea/blob/master/triplea_maps.yaml

beelee1 commented 7 years ago

Right on man. Thanks @panther2 so I forked a copy of maps yaml. Should I just add a description "Ozteas 41 Global Setup has been added". Do I need to change the version to 6.1 ? I'm thinking just the description and then do the pull request ?

panther2 commented 7 years ago

@beelee1

We do map updates in full numbers, so it would be version 7 as of now (line 340). Yes, inside the triplea_maps.yaml you could add something like "Oztea's 1941 setup" to the sentence that starts with "Now also includes Balanced Mod...." (line 347) That would be enough, IMHO.

panther2 commented 7 years ago

@simon33-2

Would you take care of this PR, please? Thank you.