search

triplea-maps / world_war_ii_global

0 stars 11 forks source link

All game.xml files need an update to handle unit repair correctly #24

Closed panther2 closed 6 years ago

panther2 commented 6 years ago

As it turned out in https://github.com/triplea-game/triplea/issues/2256 all xml-files need an update to handle the repair of capital ships correctly.

Replace: <step name="britishCombatMove" player="British" delegate="move"/>

with:

<step name="britishCombatMove" player="British" delegate="move">
<stepProperty name="combinedTurns" value="British:UK_Pacific"/>
</step>

(according to https://github.com/triplea-game/triplea/issues/2256#issuecomment-330079581 )

panther2 commented 6 years ago

The changes can be easily applied to

I successfully tested the changes with

and because of this felt encouraged to apply the changes to

too. As I am not familiar with the balanced mod, maybe someone familiar with it should double check.

However the game logic appears to be coded a bit differently in Global first edition, anyway testing the changes succeeded, so I applied the changes to

as well.

I hope everything is done correctly.

While there I resolved #23 , too.