Fix bug with UK_Pac facilities being owned by UK_Europe

[simon33-2]

This Pull Request fixes a bug in the XML which sees starting airfields and harbours in the Pacific map owned by the European economy. This causes the funds for repairs to be wrongly drawn from the European economy.

There is something in the notes about this is some maps which I've also removed in this commit.

[panther2]

Thank you for your approach!

I am no expert on the dependencies between the tripleA-engine and the map-game.xml. So please forgive me if my questions are trivial or the answers obvious...

• There is a step during the game that leads to "units changing ownership" (to British) after every UK-pacific placement, including facilities. Does your patch consider that?
• What about new facilities, bought by the Pacific economy and placed on the Pacific map. Will they keep UK-pacific as long as the territory is not captured? Will they not "change ownership" (to British), too?
• What if a UK-pacific territory with facilities is captured by Japan and afterwards recaptured by UK or another ally? The territory wil become UK-pacific of course. But will the facilites become UK-Pacific again and keep that status?

Just wondering about dependencies, implications and consequences...

[simon33-2]

Good questions P@nther2.

In fact, all of the steps you refer to already work correctly from my testing. It is only the original owner of the facilities which is wrong. If in game Kwangtung is captured and then recaptured, the owner of the harbour goes correctly to UK_Pacific even though it starts out as British!

New facilities should be fine too - I'm not changing that part but I think that it will work correctly even if placed on Korea or USSR.

It's really just the original owner that is the problem and simple to fix!

[DanVanAtta]

Looks good - this file will need to be updated next and last for the new version to go live: https://github.com/triplea-maps/Project/blob/master/production_config/triplea_maps.yaml

[simon33-2]

I don't understand what change I have to do to that file.

[DanVanAtta]

Note the new map version that was pushed out by the bot: https://github.com/triplea-maps/world_war_ii_global/releases

Then note this line: https://github.com/triplea-maps/Project/blob/master/production_config/triplea_maps.yaml#L301, which is the location/version of which map file the game will download. Currently it is at 0.9, while latest is 0.12

[panther2]

Great, simon33-2,

I have tested letting Japan build facilities in Korea. Then UK captured Korea conquering damaged facilities there. In the next UK turn, UK_pacific was correctly asked to repair the damage.
I have also tested UK_pacific building new facilities in (captured before) Korea. Later UK-pacific was correctly asked to repair the damage there, too.

I'm glad you found that fix. Thank you.