triplea-maps / world_war_ii_global

0 stars 11 forks source link

Merge balanced mod into this map, create new xmls to utilise ordered … #8

Closed simon33-2 closed 8 years ago

simon33-2 commented 8 years ago

…combats

Incorporates: https://github.com/triplea-maps/world_war_ii_g40_balanced So that map is no longer needed.

Also adds two new maps which utilise the combat ordering function from PR #1140

panther2 commented 8 years ago

Great!

While there, what do you think about #9

DanVanAtta commented 8 years ago

@simon33-2 , please confirm: https://github.com/triplea-maps/world_war_ii_g40_balanced/issues/11

DanVanAtta commented 8 years ago

@simon33-2 , I think it was actually a mistake to merge this since the map cannot be released without an updated game engine version. There were also 3 different changes in here just about, it's better for those to be split up separately. Could you do a partial revert of the BattleDelegate change so that we can release this map with the other updates?

simon33-2 commented 8 years ago

It doesn't take effect until we update the Project .yaml file and the maps which use the old logic are still present and unchanged. I don't see the harm done?

DanVanAtta commented 8 years ago

This does not use the new battle delegate? My impression was it did, in which case it would require a future version of the game engine

simon33-2 commented 8 years ago

Yes it does but until something actually references this update it won't matter. The current .yaml file refers to the old version.

Or am I missing something?

DanVanAtta commented 8 years ago

The .yaml is what live game engines will pick up. None except one built with a special branch can play v21. Which means update unit images, the merge of the two maps, is being blocked by needing a new game engine version. Any further updates to this map cannot be released either, because nobody will have a compatible game engine.

simon33-2 commented 8 years ago

Oh and since that is not in 1.9, the maps can't be updated until a new version of the engine is released. I see the problem.

DanVanAtta commented 8 years ago

Yeah, the compatibility system of maps, game engine, lobby needs some rethinking and a lot of work. We for some time have wanted to avoid the reflection that maps XML tags to java classes. Instead use lookup strings so that the classes are created explicitly on the java side and not via reflection.

If we could add an option flag to that is ignored by old game engines, but picked up by new ones, we would avoid this problem.

IMO now that we can easily update maps, and the game engine, we're going to see a lot more strain in places where versions all need to be kept in sync.