search

tripledes / thesheriff

The Sheriff
2 stars 2 forks source link

check encapsulation and create getters and setters when necessary #108

Open rmuhamed opened 4 years ago

rmuhamed commented 4 years ago

Only still pending to check domain models,

  1. Outlaw
  2. Gang
  3. Sheriff
  4. Raid

But changing to private involves a lot of changes which not worth it right now

tripledes commented 4 years ago

When adding setters/getters, please consider making the affected attributes private by adding two underscores, e.g. self.__raid_repository