triplequote / intellij-scala

Scala plugin for IntelliJ IDEA
http://blog.jetbrains.com/scala/
Apache License 2.0
0 stars 2 forks source link

Hydra integration #21

Closed maris123 closed 7 years ago

maris123 commented 7 years ago

Hydra artifacts repository is now configurable and also changed default hydra version to be the latest hydra release.

Some fixes in how Hydra compiler arguments are computed.

dragos commented 7 years ago

Looks good to me.

dragos commented 7 years ago

@maris123 Is there anything else we need before I can merge?

maris123 commented 7 years ago

@dragos If you have any time to check the last commit. I added the button to refresh the Hydra Versions.

dotta commented 7 years ago

@maris123 @dragos Has the problem I pointed out with the UI hanging on slow (missing?) internet connection been fixed?

maris123 commented 7 years ago

@dotta Yes. Now I added another button in order to get the versions from the server. So only when you click that button it will go to the repo to get the versions. But if your connection is slow it will still take some time, but you have control when you want this to happen. Before, it was getting the hydra versions every time you changed a field (username, password, repo, realm).

dotta commented 7 years ago

Mmmm, I think users will rarely hit that button and hence they might not realize a new version is available. Also, I expect some edge case when we will support importing a project via the build.sbt (the sbt-Hydra version in the build.sbt might be newer than the one in IJ).

Having said the above, I guess the current UEX is based on these two days discussions with Iulian, so I'm fine if you guys decide to merge this as is.

dragos commented 7 years ago

I guess the simplest solution is to not retrieve those versions at all and let the version entry be a dumb text field. I'm fine with that. Otherwise, I don't see a better option than a button, but I am open to suggestions. What UX did you have in mind, Mirco?

maris123 commented 7 years ago

@dragos @dotta I think it would be better to have a separate dialog after clicking the download button. Here you will have all the available versions. And you will also have in the main panel a dropdown menu with the versions of the already downloaded Hydra artifacts.

dragos commented 7 years ago

I think this might be confusing, since the user may choose a version in the main panel, then he's asked again about the Hydra version in the new dialog. "Refresh Versions" sounds like a good compromise

maris123 commented 7 years ago

Maybe, but this is similar to how downloading Scala SDK works. You have a list with scala versions that you already downloaded and you can select which one you want to use in your project. If you want another version you have to click download and a separate dialog appears where you can select which version you want to download.

dragos commented 7 years ago

I like it, so I would merge it as-is. We can always refine it later.

screen shot 2017-11-03 at 16 59 39
dragos commented 7 years ago

@dotta, if you're happy with it, let's merge. I'd like to open the PR to Jetbrains on Monday morning:

justin.kaeser [1:50 PM] we're aiming to feature freeze next week, so ideally we will merge hydra support then as well

dotta commented 7 years ago

Sure, go ahead