trippsc2 / OpenTracker

An open-source cross-platform tracking application for A Link to the Past Randomizer.
MIT License
35 stars 9 forks source link

Aga Tower Autotracking Issue #52

Closed t3hf1gm3nt closed 3 years ago

t3hf1gm3nt commented 3 years ago

The checks for Aga Tower seem to keep getting decremented by 8 and sometimes 12 when doing checks inside Tower of Hera when race illegal autotracking is on. I've noticed Aga Tower checks going into the negatives between -6 and even -10, and I think I finally pinpointed it to anytime a check is done in Tower of Hera.

trippsc2 commented 3 years ago

Thanks for the report. I'll look get this resolved in the next version release. As I've posted on other issues, I won't be doing much development on this for a few weeks, as I've got a few very busy weeks coming up.

DorkmasterFlek commented 3 years ago

I was about to report the same issue, just tried this program for the first time and it works great otherwise. The issue looks to be in address $7EF435 where the dungeon location check counts happen. Most of these bytes are two dungeons split evenly between the upper and lower halves of the byte, but this one is different. From the Z3R ASM stats comments:

; $7EF435 - dddhhhaa - item locations checked
; d - desert palace
; h - tower of hera
; a - agahnim's tower

If the Aga Tower count is taking the entire lower half of this byte, that explains why making checks in ToH changes it. There is one other byte which does not have an even upper/lower half split as well:

; $7EF436 - gggggeee - item locations checked
; g - ganon's tower
; e - eastern palace

All the other bytes are split between upper and lower halves evenly.

trippsc2 commented 3 years ago

You're right. I input the wrong mask for that address. It has been fixed and v1.5.2 has been released to address this.