search

tripviss / image-resizer

On-the-fly image resizing using Node.js and libvips. Heroku Ready!
MIT License
73 stars 45 forks source link

The image file name is no longer transformed to lower case #41

Open arnee opened 7 years ago

arnee commented 7 years ago

For now in case there is a requested output format and the image file name is written in mixed spelling, amazon s3 returns an 'The specified key does not exist.'-error since it is case sensitive. So the file name should not be transformed to lower case.

macx commented 7 years ago

Thank you @arnee to find and fix the bug.

teohhanhui commented 7 years ago

Thanks for catching this, but that's not the right fix. I'll change it so that String::toLowerCase is only called for the actual extension parts.

teohhanhui commented 7 years ago

@arnee @macx Please let me know if my fix works properly. :smile:

arnee commented 7 years ago

Thanks @teohhanhui your solution makes more sense.