Closed dnebauer closed 10 months ago
Hi @dnebauer thank you for letting me know
I wonder if this could be handled in #70 as part of the work @willothy is doing
Yeah that definitely falls under the scope of that issue. We do pretty much no path validation right now, which could definitely lead to a lot of issues. I will make sure to use libuv to check to symlinks and such in the PR for that. Should hopefully have a draft up at least later today.
On my first attempted use of this plugin I tried the
HawtkeysAll
command and got the following error:The file path given in the error message was a broken symlink. The broken symlink was some cruft and I took the opportunity to remove it, after which the plugin command worked fine.
If you're happy for the plugin command to fail on a broken symlink please feel free to close this issue -- I can't think of a situation where a user would want to keep broken symlinks, and they might appreciate your plugin bringing these broken links to their attention.
Alternatively, you might want the plugin to handle this situation more gracefully, perhaps silently ignoring broken symlinks.