Added option for local playback

trishika / DroidUPnP

DroidUPnP is an upnp control point application for android.

GNU General Public License v3.0

150 stars 61 forks source link

Added option for local playback #32

Closed Benny- closed 9 years ago

Benny- commented 10 years ago

This is a solution for issue #31

Long press on a item will show the option "Launch local viewer":

remote/local music items will launch the default music player and play it
remote/local video items will launch the default video player and play it
remote pictures will NOT work, not supported using android apps
local pictures will launch the default picture viewer

Long press on a directory result in a toast: "No action available"

trishika commented 10 years ago

This is a nice simple way to get this feature implemented. But :

I'd rather see that code in an outside class
Text that is intended to be display should be put into the string resource file and if possible translate into all the supported language (translation can be done later).
Using the long press to trigger the local rendering is not really explicit and most of the user will miss this feature. The best solution would be to have the local renderer into the renderer list. But as this is not a real renderer ( no remote playing information ), it would need some special treatment.

Benny- commented 10 years ago

I am prepared to solve the first two problems.

The 3th problem (showing local renderer in the list of renderer) will take considerable more effort. Are you sure you want it implemented that way? Please close this merge request if that is the case.

escoand commented 10 years ago

I would also prefer trishika's solution. It's more intuitive to the user. Yes it's not intuitive for the coder but i like droidupnp for it's ease of use.

trishika commented 10 years ago

I am not against merging the feature as it is right now and delay the more intuitive implementation for now. But yes at the end I really want to see the local renderer in the renderer list.

escoand commented 10 years ago

YAACC uses the long press behavior to allow queuing and downloading of items. Maybe this could be implemented with this popup...

Benny- commented 10 years ago

The strings shown are now in the resource file.

In what way would you like the code encapsulated in a seperate class, @trishika? Please be as specific as possible.

mmhobi7 commented 10 years ago

@Benny- I think he wants you to make a new class, and just refer to it from the main... For ex: LocalPlay.java and you refer to it from main

Benny- commented 9 years ago

Closed due to lack of interest.